RFR: 8255572: Axis does not compute preferred height properly when autoRanging is off [v6]
Jonathan Vusich
github.com+31666175+jonathanvusich at openjdk.java.net
Mon Feb 1 23:12:08 UTC 2021
> As noted in the corresponding JBS issue, `Axis` does not properly compute its preferred height when `autoRanging` is turned off. The simplest fix seems to be changing `CategoryAxis` so that `tickLabelRotation` is set to 90 degrees if there is not enough room for the category labels to layout horizontally. This fixes the fact that the axis labels are truncated and also ensures that the chart does not leave unused space from the layout calculations. `CategoryAxis` is already setting the `categorySpacing` property when `autoRanging` is off, so this seems to be an appropriate fix.
Jonathan Vusich has updated the pull request incrementally with two additional commits since the last revision:
- Add tests for vertical axis as well
- Improve layout calculations for rotated text
-------------
Changes:
- all: https://git.openjdk.java.net/jfx/pull/342/files
- new: https://git.openjdk.java.net/jfx/pull/342/files/dff9ee17..d5a3fae9
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jfx&pr=342&range=05
- incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=342&range=04-05
Stats: 134 lines in 3 files changed: 120 ins; 1 del; 13 mod
Patch: https://git.openjdk.java.net/jfx/pull/342.diff
Fetch: git fetch https://git.openjdk.java.net/jfx pull/342/head:pull/342
PR: https://git.openjdk.java.net/jfx/pull/342
More information about the openjfx-dev
mailing list