RFR: 8255572: Axis does not compute preferred height properly when autoRanging is off [v6]

Jonathan Vusich github.com+31666175+jonathanvusich at openjdk.java.net
Mon Feb 1 23:15:46 UTC 2021


On Mon, 1 Feb 2021 21:37:44 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> @JonathanVusich Once a review is in progress, please don't force-push your branch without a compelling reason, since that makes it harder to do incremental reviews. In the future, we recommend `git merge master` rather than `git rebase master`, since the former doesn't require force-pushing.
>
> I do see that there are no changes from last time, which is good, so it will be fine for this time.
> 
> When ready, you can add the new test by pushing a new commit.

@kevinrushforth I was not aware of that, thank you for letting me know! 
I wrote a new test for vertical axes and discovered that there were more issues with axis layout calculations, which I also addressed.

I also found out that the layout tests sometimes fail without a short pause using `Util.sleep()`. I don't really like having to add sleeps, but I did find that it got rid of any test flakiness.

-------------

PR: https://git.openjdk.java.net/jfx/pull/342


More information about the openjfx-dev mailing list