RFR: 8252935: Add treeShowing listener only when needed [v6]

Ambarish Rapte arapte at openjdk.java.net
Mon Feb 15 08:42:44 UTC 2021


On Wed, 10 Feb 2021 21:56:01 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

>> This is a PoC for performance testing.  
>> 
>> It contains commented out code in PopupWindow and ProgressIndicatorSkin and two tests are failing because of that.
>> 
>> This code avoids registering two listeners (on Scene and on Window) for each and every Node to support the aforementioned classes.  The complete change should update these two classes to add their own listeners instead.
>
> John Hendrikx has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add missed null checks to fix test failure

Looks good to me.

-------------

Marked as reviewed by arapte (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/185


More information about the openjfx-dev mailing list