RFR: WIP: 8260528: Clean glass-gtk sizing and positioning code [v10]
Thiago Milczarek Sayao
tsayao at openjdk.java.net
Wed Feb 17 20:20:53 UTC 2021
> This is a new approach to rewrite parts of gtk glass backend to be more clean.
>
> I will provide small "manageable" PR to incrementally make the backend better.
>
> This PR adresses cleanup of the Size and Positioning code. It makes code more "straightforward" and easier to maintain.
>
> Current status (Ubuntu 20.04):
> 
>
> (*) Some of the iconify tests are also failing on the main branch.
>
> `gradlew -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests test.robot.javafx.stage.IconifyTest` on a second run produces 4 tests, 2 failures.
Thiago Milczarek Sayao has updated the pull request incrementally with one additional commit since the last revision:
Turns out gravity is used!
-------------
Changes:
- all: https://git.openjdk.java.net/jfx/pull/367/files
- new: https://git.openjdk.java.net/jfx/pull/367/files/30d5291e..636114b5
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jfx&pr=367&range=09
- incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=367&range=08-09
Stats: 21 lines in 2 files changed: 5 ins; 15 del; 1 mod
Patch: https://git.openjdk.java.net/jfx/pull/367.diff
Fetch: git fetch https://git.openjdk.java.net/jfx pull/367/head:pull/367
PR: https://git.openjdk.java.net/jfx/pull/367
More information about the openjfx-dev
mailing list