RFR: 8258777: SkinBase: add api to un-/register invalidation-/listChange listeners

Jeanette Winzenburg fastegal at openjdk.java.net
Tue Feb 23 11:16:42 UTC 2021


On Mon, 22 Feb 2021 20:25:42 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Changes in Lambda..Handler:
>> - added api and implemenation to support invalidation and listChange listeners in the same way as changeListeners
>> - added java doc 
>> - added tests
>> 
>> Changes in SkinBase
>> - added api (and implementation delegating to the handler)
>> - copied java doc from the change listener un/register methods 
>> - added tests to verify that the new (and old) api is indeed delegating to the handler
>> 
>> Note that the null handling is slightly extended: all methods now can handle both null consumers (as before) and null observables (new) - this allows simplified code on rewiring "path" properties (see reference example in the issue)
>
> modules/javafx.controls/src/main/java/javafx/scene/control/SkinBase.java line 269:
> 
>> 267:      *      {@link #registerInvalidationListener(Observable, Consumer)}. If no consumers have been registered on this
>> 268:      *      property, null will be returned.
>> 269:      * @since 9
> 
> Need to change `9` to `17`.

darn .. bloody c&p ;)

-------------

PR: https://git.openjdk.java.net/jfx/pull/409


More information about the openjfx-dev mailing list