RFR: 8259635: Update to 610.2 version of WebKit
Johan Vos
jvos at openjdk.java.net
Thu Jan 21 18:29:35 UTC 2021
On Thu, 21 Jan 2021 14:05:54 GMT, Arun Joseph <ajoseph at openjdk.org> wrote:
>> I reviewed all of the changes outside `modules/javafx.web/src/main/native/`. Most look related to the change to use the Prism Color object instead of an int. I did have a question about one of those changes:
>>
>> modules/javafx.web/src/main/java/com/sun/webkit/plugin/DefaultPlugin.java
>> - g.fillRect(x, y, w, h, 0x11aaffff);
>> + g.fillRect(x, y, w, h, new Color(0.33f, 1.0f, 1.0f, 0.1f));
>>
>> These are not equivalent colors. Is this intentional?
>
> It should be `new Color(2 / 3.0f, 1.0f, 1.0f, 1 / 15.0f)`. I'll update the PR.
Build and tests pass on windows/linux/mac in our CI.
-------------
PR: https://git.openjdk.java.net/jfx/pull/382
More information about the openjfx-dev
mailing list