RFR: 8228363: ContextMenu.show with side=TOP does not work the first time in the presence of CSS [v2]
rlichten at openjdk.java.net
Fri Jan 22 12:02:13 UTC 2021
> By using the anchor location facility of PopupWindows we can avoid miscalculation of the
> menu's height entirely.
> This fix also cleans up some documentation issues.
> This fix introduces tests that check the correct positioning (test_position_)
> test_position_withCSS reproduces the problem that is fixed with this patch.
> The other test_position_ cases serve as "proof" that no regressions are introduces.
> They work before and after the fix is introduced.
Robert Lichtenberger has updated the pull request incrementally with one additional commit since the last revision:
8228363: ContextMenu.show with side=TOP does not work the first time in the presence of CSS
Corrections as per Kevin Rushforth's comments.
Also added two more test cases that test right-to-left node orientation.
Fixed the implementation and the API documentation.
- all: https://git.openjdk.java.net/jfx/pull/383/files
- new: https://git.openjdk.java.net/jfx/pull/383/files/48d6453a..67a7da14
- full: https://webrevs.openjdk.java.net/?repo=jfx&pr=383&range=01
- incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=383&range=00-01
Stats: 123 lines in 3 files changed: 87 ins; 29 del; 7 mod
Fetch: git fetch https://git.openjdk.java.net/jfx pull/383/head:pull/383
More information about the openjfx-dev