RFR: 8252935: Add treeShowing listener only when needed [v3]

John Hendrikx jhendrikx at openjdk.java.net
Sun Jan 24 15:25:06 UTC 2021


> This is a PoC for performance testing.  
> 
> It contains commented out code in PopupWindow and ProgressIndicatorSkin and two tests are failing because of that.
> 
> This code avoids registering two listeners (on Scene and on Window) for each and every Node to support the aforementioned classes.  The complete change should update these two classes to add their own listeners instead.

John Hendrikx has updated the pull request incrementally with two additional commits since the last revision:

 - Add performance test
 - Use registerChangeListener in ProgressIndicatorSkin

-------------

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/185/files
  - new: https://git.openjdk.java.net/jfx/pull/185/files/5ac5d9e4..e68a886d

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jfx&pr=185&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=185&range=01-02

  Stats: 170 lines in 2 files changed: 167 ins; 2 del; 1 mod
  Patch: https://git.openjdk.java.net/jfx/pull/185.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/185/head:pull/185

PR: https://git.openjdk.java.net/jfx/pull/185


More information about the openjfx-dev mailing list