RFR: 8236651: Simplify and update glass gtk backend

Thiago Milczarek Sayao tsayao at openjdk.java.net
Mon Jan 25 01:21:40 UTC 2021


On Tue, 22 Sep 2020 01:12:44 GMT, Thiago Milczarek Sayao <tsayao at openjdk.org> wrote:

>> Rebased onto "master" and squashed commits.
>
> Tested on Ubuntu 20.04
> 
> 756 tests completed, 6 failed, 110 skipped
> 
> Failed:
> test.robot.javafx.scene.ColorPickerTest > testColorPickerSceneChange FAILED
>     java.lang.AssertionError: Timeout: Failed to receive onAction callback.
>         at org.junit.Assert.fail(Assert.java:91)
>         at org.junit.Assert.assertTrue(Assert.java:43)
>         at test.robot.javafx.scene.ColorPickerTest.waitForLatch(ColorPickerTest.java:203)
>         at test.robot.javafx.scene.ColorPickerTest.clickColorPickerPalette(ColorPickerTest.java:88)
>         at test.robot.javafx.scene.ColorPickerTest.testColorPickerSceneChange(ColorPickerTest.java:119)
> 
> test.robot.javafx.scene.RobotTest > testKeyPress FAILED
>     org.junit.ComparisonFailure: letter 'a' should be pressed by Robot expected:<[a]> but was:<[]>
>         at org.junit.Assert.assertEquals(Assert.java:123)
>         at test.robot.javafx.scene.RobotTest.testKeyboard(RobotTest.java:193)
>         at test.robot.javafx.scene.RobotTest.testKeyPress(RobotTest.java:144)
> 
> test.robot.javafx.scene.tableview.TableViewResizeColumnToFitContentTest > resizeColumnToFitContentTest FAILED
>     java.lang.AssertionError: resizeColumnToFitContent failed
>         at org.junit.Assert.fail(Assert.java:91)
>         at org.junit.Assert.assertTrue(Assert.java:43)
>         at test.robot.javafx.scene.tableview.TableViewResizeColumnToFitContentTest.resizeColumnToFitContentTest(TableViewResizeColumnToFitContentTest.java:96)
> 
> test.robot.javafx.stage.IconifyTest > canIconifyDecoratedStage FAILED
>     junit.framework.AssertionFailedError: expected:rgba(255,0,0,255) but was:rgba(62,62,62,255)
>         at test.robot.testharness.VisualTestBase.assertColorEquals(VisualTestBase.java:179)
>         at test.robot.javafx.stage.IconifyTest.lambda$canIconifyStage$4(IconifyTest.java:97)
> 
> test.robot.javafx.stage.IconifyTest > canIconifyTransparentStage FAILED
>     junit.framework.AssertionFailedError: expected:rgba(0,255,0,255) but was:rgba(88,88,88,255)
>         at test.robot.testharness.VisualTestBase.assertColorEquals(VisualTestBase.java:179)
>         at test.robot.javafx.stage.IconifyTest.lambda$canIconifyStage$6(IconifyTest.java:108)
> 
> test.robot.javafx.stage.IconifyTest > canIconifyNonResizableStage FAILED
>     junit.framework.AssertionFailedError: expected:rgba(255,0,0,255) but was:rgba(44,44,44,255)
>         at test.robot.testharness.VisualTestBase.assertColorEquals(VisualTestBase.java:179)
>         at test.robot.javafx.stage.IconifyTest.lambda$canIconifyStage$4(IconifyTest.java:97)
> 
> 
> For some reason the html report is not being generated.
> 
> **Second run:**
> 756 tests completed, 4 failed, 110 skipped
> 
> test.robot.javafx.scene.RobotTest > testKeyPress FAILED
>     org.junit.ComparisonFailure: letter 'a' should be pressed by Robot expected:<[a]> but was:<[]>
>         at org.junit.Assert.assertEquals(Assert.java:123)
>         at test.robot.javafx.scene.RobotTest.testKeyboard(RobotTest.java:193)
>         at test.robot.javafx.scene.RobotTest.testKeyPress(RobotTest.java:144)
> 
> test.robot.javafx.stage.IconifyTest > canIconifyDecoratedStage FAILED
>     junit.framework.AssertionFailedError: expected:rgba(255,0,0,255) but was:rgba(44,44,44,255)
>         at test.robot.testharness.VisualTestBase.assertColorEquals(VisualTestBase.java:179)
>         at test.robot.javafx.stage.IconifyTest.lambda$canIconifyStage$4(IconifyTest.java:97)
> 
> test.robot.javafx.stage.IconifyTest > canIconifyTransparentStage FAILED
>     junit.framework.AssertionFailedError: expected:rgba(0,255,0,255) but was:rgba(88,88,88,255)
>         at test.robot.testharness.VisualTestBase.assertColorEquals(VisualTestBase.java:179)
>         at test.robot.javafx.stage.IconifyTest.lambda$canIconifyStage$6(IconifyTest.java:108)
> 
> test.robot.javafx.stage.IconifyTest > canIconifyNonResizableStage FAILED
>     junit.framework.AssertionFailedError: expected:rgba(255,0,0,255) but was:rgba(44,44,44,255)
>         at test.robot.testharness.VisualTestBase.assertColorEquals(VisualTestBase.java:179)
>         at test.robot.javafx.stage.IconifyTest.lambda$canIconifyStage$4(IconifyTest.java:97)

I would prefer this approach:
https://github.com/openjdk/jfx/pull/367

-------------

PR: https://git.openjdk.java.net/jfx/pull/77


More information about the openjfx-dev mailing list