RFR: 8228363: ContextMenu.show with side=TOP does not work the first time in the presence of CSS [v3]
Robert Lichtenberger
rlichten at openjdk.java.net
Mon Jan 25 11:40:08 UTC 2021
> By using the anchor location facility of PopupWindows we can avoid miscalculation of the
> menu's height entirely.
> This fix also cleans up some documentation issues.
> This fix introduces tests that check the correct positioning (test_position_)
> test_position_withCSS reproduces the problem that is fixed with this patch.
> The other test_position_ cases serve as "proof" that no regressions are introduces.
> They work before and after the fix is introduced.
Robert Lichtenberger has updated the pull request incrementally with one additional commit since the last revision:
8228363: ContextMenu.show with side=TOP does not work the first time in the presence of CSS
Removed node orientation from API doc.
Removed extra blank lines.
-------------
Changes:
- all: https://git.openjdk.java.net/jfx/pull/383/files
- new: https://git.openjdk.java.net/jfx/pull/383/files/67a7da14..b02dcb02
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jfx&pr=383&range=02
- incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=383&range=01-02
Stats: 8 lines in 1 file changed: 0 ins; 6 del; 2 mod
Patch: https://git.openjdk.java.net/jfx/pull/383.diff
Fetch: git fetch https://git.openjdk.java.net/jfx pull/383/head:pull/383
PR: https://git.openjdk.java.net/jfx/pull/383
More information about the openjfx-dev
mailing list