[jfx16] RFR: 8252389: Fix mistakes in FX API docs [v2]

Kevin Rushforth kcr at openjdk.java.net
Sat Jan 30 15:40:45 UTC 2021


On Fri, 29 Jan 2021 16:17:02 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> The usual doc fixes (for OpenJFX 16).
>> 
>> Can wait until RDP2 to see if something else comes up.
>
> Nir Lisker has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix for 8260430

I left two additional comments. Otherwise good.

modules/javafx.base/src/main/java/javafx/collections/ListChangeListener.java line 195:

> 193:          * Note that using set will also produce a change with {@code wasRemoved()} returning
> 194:          * true. See {@link #wasReplaced()}.
> 195:          * @return {@code true} if something was removed from the list

This same change could be applied to `wasAdded`.

modules/javafx.controls/src/main/java/javafx/scene/control/MenuItem.java line 509:

> 507:      * set.
> 508:      *
> 509:      * @return the user object that was stored (including {@code null}), or {@code null} if no object has been set.

Trailing `.` can be removed.

-------------

PR: https://git.openjdk.java.net/jfx/pull/380


More information about the openjfx-dev mailing list