RFR: 8185447: The special high-contrast mode of JavaFX Controls in Japanese environment do not work.

Johan Vos jvos at openjdk.java.net
Fri Jul 2 11:28:05 UTC 2021


On Wed, 26 May 2021 20:39:32 GMT, Jose Pereda <jpereda at openjdk.org> wrote:

> This PR adds several resource bundles with High Contrast Scheme possible values for several locales. 
> 
> These values have been found by installing the required language packages on Windows 10 Pro 20H2 (build 19042.985), enabling Settings->High Contrast and finding the high contrast scheme values in the Windows registry (and translating to unicode when needed). Other locales could be generated as well, but so far the list is the same as the locales supported by Controls.
> 
> With these bundles, and assuming the application uses a locale that matches the system settings language, the theme name provided natively (only on Windows so far) can be matched with the high contrast scheme, and the proper stylesheet can be applied.
> 
> This PR has been tested on the same Windows machine, selecting each possible language and setting the locale for the app accordingly.

modules/javafx.graphics/src/main/java/com/sun/javafx/application/PlatformImpl.java line 734:

> 732:         }
> 733: 
> 734:         public static String fromThemeName(Function<String, String> keyFunction, String themeName) {

Would be good to get a bit of (java)doc here so that it is clear what this function is doing.

-------------

PR: https://git.openjdk.java.net/jfx/pull/520


More information about the openjfx-dev mailing list