RFR: 8187229: Tree/TableCell: cancel event must return correct editing location [v2]

[Jeanette Winzenburg]

On Sat, 3 Jul 2021 13:10:54 GMT, Marius Hanl <mhanl at openjdk.org> wrote:

>> Jeanette Winzenburg has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   test cleanup as per review comments
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/TableCellTest.java line 530:
> 
>> 528:      */
>> 529:     @Test
>> 530:     public void testEditCancelMemoryLeakAfterRemoveEditingItem() {
> 
> I took a while to understand this test. 
> Maybe one more sentence with information would be helpful here (and same test in TreeTableCell).
> 
> (My first thought was we are testing basically WeakReference, but then I figured out we want to test whether there are some references left somewhere which prevents the GC or not. So a small sentence like this would be nice in my opinion :))

actually, I went the opposite direction: aligned all method comments to those in TreeCellTest (which boiled down to removing nearly all :)

-------------

PR: https://git.openjdk.java.net/jfx/pull/561