Integrated: 8187229: Tree/TableCell: cancel event must return correct editing location

Jeanette Winzenburg fastegal at openjdk.java.net
Tue Jul 6 09:04:56 UTC 2021


On Thu, 1 Jul 2021 12:38:06 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

> the bug is an incorrect edit location (for Tree/Table: Tree/TablePosition) in edit cancel events - expected is the location at the time the cell edit was started, actual was the location of at the time the edit was cancelled. See the report for details.
> 
> The fix is analogue to those for ListCell/TreeCell, that is storing the edit location in startEdit and use that in cancelEdit.
> 
> Added tests that failed before and passed after and tests that (accidentally :) passed before and still pass after.
> 
> Related issues:
> 
> - also fixes [JDK-8269136](https://bugs.openjdk.java.net/browse/JDK-8269136) (Tree/TablePosition: must not throw NPE on instantiating with null table), in hind-sight it seemed too small to warrant its own PR. 
> - does not fix the implementation of CellEditEvent (todo: file follow-up issue) which must not throw with null Tree/TablePosition.

This pull request has now been integrated.

Changeset: 47c2ec3d
Author:    Jeanette Winzenburg <fastegal at openjdk.org>
URL:       https://git.openjdk.java.net/jfx/commit/47c2ec3d01d9870134c664205d511d54d9c6e85d
Stats:     374 lines in 7 files changed: 347 ins; 15 del; 12 mod

8187229: Tree/TableCell: cancel event must return correct editing location
8269136: Tree/TablePosition: must not throw NPE on instantiating with null table

Reviewed-by: mhanl, aghaisas

-------------

PR: https://git.openjdk.java.net/jfx/pull/561


More information about the openjfx-dev mailing list