RFR: 8268849: Update to 612.1 version of WebKit [v2]

Ambarish Rapte arapte at openjdk.java.net
Tue Jul 6 12:11:55 UTC 2021


On Thu, 1 Jul 2021 22:03:48 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Ambarish Rapte has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - remove unwanted file
>>  - comment failing test code
>
> modules/javafx.web/src/test/java/test/javafx/scene/web/HistoryTest.java line 100:
> 
>> 98:         //
>> 99:         // check the title update
>> 100:         //
> 
> Since this uses a listener to read the title property, why did this check need to be removed? We might want to file a P4 test bug to look into adding it back in. To that end, do you think it is better to comment this block of code out rather than delete it?

I have reverted this change and commented the test and created [JDK-8269912](https://bugs.openjdk.java.net/browse/JDK-8269912) to investigate test.

> modules/javafx.web/src/test/java/test/javafx/scene/web/LoadNotificationsTest.java line 153:
> 
>> 151:                         assertNull("WebEngine.title should be null", web.getTitle());
>> 152:                     } else {
>> 153:                         assertNotNull("WebEngine.title should be set", web.getTitle());
> 
> Similar to the comment I made in `HistoryTest`, is it worth filing a P4 test bug to look at converting this to use a listener? If so, then leaving this in, but commented out might be a good idea.

I have reverted this change and commented the code and created [JDK-8269912](https://bugs.openjdk.java.net/browse/JDK-8269912) to investigate test.

-------------

PR: https://git.openjdk.java.net/jfx/pull/560


More information about the openjfx-dev mailing list