RFR: 8266743: crash on macOS 10.11 due to ignored check on 10.12 [v2]

[Kevin Rushforth]

On Tue, 6 Jul 2021 23:32:23 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> This fix restores the minimum macOS version needed to run JavaFX on x64 platforms to 10.10.
>> 
>> The fix for [JDK-8265031](https://bugs.openjdk.java.net/browse/JDK-8265031) bumped the minimum version for macOS on aarch64 to 11.0 and on x64 to 10.12. The change on aarch64 was necessary, since that is the minimum version that will run on Apple Silicon. The change on x64 was not necessary, but was done to match JDK 17. In connection with the fix for [JDK-8263169](https://bugs.openjdk.java.net/browse/JDK-8263169), this causes a crash on older macOS systems running 10.10 or 10.11. The long term solution is to detect and throw an exception at startup if the version of macOS is below the minimum, but for JavaFX 17 it was felt that restoring the minimum of macOS 10.10 for x64 platforms was safer.
>> 
>> See the discussion in JBS for more information.
>
> Kevin Rushforth has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Revert "8266743: JavaFX should fail fast on macOS below minimum version"
>    
>    This reverts commit 863c09e9753fded3492ee5cb636018e4e76c9dba.
>  - 8266743: JavaFX should fail fast on macOS below minimum version

There were failing macOS pre-submit tests. It looks like some sort of intermittent test issue, and in any case is unrelated to this change since the initial commit, with 100% identical content passed. However, I pushed a dummy  commit to rerun the tests to remove any question.

-------------

PR: https://git.openjdk.java.net/jfx/pull/566