RFR: 8089398: [ChoiceBox, ComboBox] throws NPE on setting value on null selectionModel [v3]

Marius Hanl mhanl at openjdk.java.net
Wed Jul 7 19:32:51 UTC 2021


On Wed, 7 Jul 2021 11:18:41 GMT, Ajit Ghaisas <aghaisas at openjdk.org> wrote:

>> Marius Hanl has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Added another cbx test + cleaned up exception handler + let the exception bubble up instead of try-catch
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/ComboBoxListViewSkin.java line 401:
> 
>> 399:     private void updateValue() {
>> 400:         SingleSelectionModel<T> comboBoxSM = comboBox.getSelectionModel();
>> 401:         if (comboBoxSM == null) {
> 
> Similar null check can be added to layoutChildren() method as well.

added.

-------------

PR: https://git.openjdk.java.net/jfx/pull/557


More information about the openjfx-dev mailing list