RFR: 8089398: [ChoiceBox, ComboBox] throws NPE on setting value on null selectionModel [v4]
Marius Hanl
mhanl at openjdk.java.net
Wed Jul 7 19:37:23 UTC 2021
> This PR fixes 2 NPEs in Choice-and ComboBox, when the selection model is null.
>
> ChoiceBox:
> - Null check in **valueProperty()** listener
>
> ComboBox:
> - Null check in **valueProperty()** listener
> - Null check in **ComboBoxListViewSkin#updateValue()**
>
> The tests checks, that no NPE is printed to the console. They also checks, that the set value is still displayed (either in the ComboBox button cell or the ChoiceBox display label)
Marius Hanl has updated the pull request incrementally with two additional commits since the last revision:
- Fixed NPE for setEditable() and layoutChildren()
- removed unneeded button cell in test
-------------
Changes:
- all: https://git.openjdk.java.net/jfx/pull/557/files
- new: https://git.openjdk.java.net/jfx/pull/557/files/0b631ed4..b064f61e
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jfx&pr=557&range=03
- incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=557&range=02-03
Stats: 37 lines in 3 files changed: 31 ins; 1 del; 5 mod
Patch: https://git.openjdk.java.net/jfx/pull/557.diff
Fetch: git fetch https://git.openjdk.java.net/jfx pull/557/head:pull/557
PR: https://git.openjdk.java.net/jfx/pull/557
More information about the openjfx-dev
mailing list