RFR: 8089398: [ChoiceBox, ComboBox] throws NPE on setting value on null selectionModel [v3]

[Marius Hanl]

On Wed, 7 Jul 2021 10:24:59 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

>> Marius Hanl has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Added another cbx test + cleaned up exception handler + let the exception bubble up instead of try-catch
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/ComboBoxTest.java line 319:
> 
>> 317: 
>> 318:         ComboBox<String> comboBox = new ComboBox<>();
>> 319:         comboBox.setButtonCell(buttonCell);
> 
> KISS - the buttonCell or not has no effect if there is no skin :)

oh damn, right. fixed it.

-------------

PR: https://git.openjdk.java.net/jfx/pull/557