RFR: 8188026: TextFieldXXCell: NPE on calling startEdit

Jeanette Winzenburg fastegal at openjdk.java.net
Fri Jul 9 10:53:48 UTC 2021


On Thu, 8 Jul 2021 19:44:12 GMT, Marius Hanl <mhanl at openjdk.org> wrote:

> 
> Do we wanna create follow-ups for this, so this PR won''t get any bigger? That would be at least my preference.
> Right now I see:
> 
>     * !isEditing check in cancelEdit() (we can return directly)
> 
>     * isEditing check in startEdit() (we can return directly)
> 
> 
> Is there more?

just checked my notes (there's a cell-editing branch in my fork where I'm experimenting) - astonishingly the answer is no, could not see anything :) And actually, seems like we don't even need to return immediately: would have expected some unhealthy side-effects on doing the switching into visual editing state more than once, but couldn't detect anything. You might try, though :)

-------------

PR: https://git.openjdk.java.net/jfx/pull/569


More information about the openjfx-dev mailing list