RFR: 8269967: JavaFX should fail fast on macOS below minimum version
Johan Vos
jvos at openjdk.java.net
Fri Jul 9 13:00:56 UTC 2021
On Fri, 9 Jul 2021 12:20:53 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
> Alternatively, I could add a new JNI function to check the version, and call that right after the `loadLibrary`. That might be cleaner than doing it as part of `initIDs`
I think it's ok to keep it in the initIDs, as that is called immediately after the loadLibrary. A new JNI function seems a bit overkill -- it would have fit nicely in the JNI_OnLoad but I do agree that that is not the best approach, since it will convert the exception/error into an UnsatiffiedLinkError.
Hence, +1 on your current approach with doing it in initIDs.
-------------
PR: https://git.openjdk.java.net/jfx/pull/567
More information about the openjfx-dev
mailing list