RFR: 8269967: JavaFX should fail fast on macOS below minimum version [v2]
Kevin Rushforth
kcr at openjdk.java.net
Fri Jul 9 13:19:20 UTC 2021
> This PR implements a version check in the JavaFX runtime initialization code on macOS to ensure that the platform is running a version of macOS that is at or above the minimum version. If the platform is below the specified minimum, the JavaFX initialization code throws an exception.
>
> The minimum version is passed from the `mac.gradle` file to the Mac glass code as a pair of build time constants, which are compared at runtime to the platform version.
>
> Notes to reviewers:
>
> * In case anyone is interested, the first commit has some debug logging which will print the minimum version and the detected platform version. I removed them with the second commit.
Kevin Rushforth has updated the pull request incrementally with one additional commit since the last revision:
Move version check to beginning of initIDs
-------------
Changes:
- all: https://git.openjdk.java.net/jfx/pull/567/files
- new: https://git.openjdk.java.net/jfx/pull/567/files/6d4cdd61..4e24d454
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jfx&pr=567&range=01
- incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=567&range=00-01
Stats: 56 lines in 1 file changed: 28 ins; 28 del; 0 mod
Patch: https://git.openjdk.java.net/jfx/pull/567.diff
Fetch: git fetch https://git.openjdk.java.net/jfx pull/567/head:pull/567
PR: https://git.openjdk.java.net/jfx/pull/567
More information about the openjfx-dev
mailing list