RFR: 8269429: Linux: Only the last APPLICATION_MODAL window behaves correctly [v2]

Thiago Milczarek Sayao tsayao at openjdk.java.net
Sat Jul 10 16:06:19 UTC 2021


On Fri, 9 Jul 2021 18:41:11 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Thiago Milczarek Sayao has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Reuse existing set_modal (which was previously unused).
>
> modules/javafx.graphics/src/main/native-glass/gtk/glass_window.cpp line 1436:
> 
>> 1434:             gtk_window_set_transient_for(GTK_WINDOW(gtk_widget), parent->get_gtk_window());
>> 1435:         } else {
>> 1436:             gtk_window_set_keep_above(GTK_WINDOW(gtk_widget), modal ? TRUE : FALSE);
> 
> The test of `modal` is unnecessary here, since this is all within an `if (modal)` block.

Done.

-------------

PR: https://git.openjdk.java.net/jfx/pull/551


More information about the openjfx-dev mailing list