RFR: 8269638: Property methods, setters, and getters in printing API should be final

[Kevin Rushforth]

On Mon, 12 Jul 2021 18:50:34 GMT, Phil Race <prr at openjdk.org> wrote:

> - Make various setters and getters and properties final as needed
> - Move documentation to the property so the setters and getters inherit it, with an exception for the special case of JobSettings.setPageRanges()
> - Override toString() on the properties in JobSettings so it doesn't delegate to the JobSettings class.
> - Add a manual test program just so you can see what toString() does. No pass or fail, just informative.
> 
> This will need a CSR but I won't create that until the review is done.

Two quick comments, otherwise looks good (I'll do a more detailed review of the added docs as well we double-check that nothing else was missed).

1. `PrinterJob::setPrinter` is not `final` (and probably some / all of the docs could move to the property).
2. There are two new warnings about empty `<p>` tags:


jfx/modules/javafx.graphics/src/main/java/javafx/print/JobSettings.java:968: warning: empty <p> tag
     * <p>
       ^
jfx/modules/javafx.graphics/src/main/java/javafx/print/JobSettings.java:1049: warning: empty <p> tag
     * <p>
       ^

modules/javafx.graphics/src/main/java/javafx/print/JobSettings.java line 968:

> 966:      * and it is safest to stick to selecting a standard value that
> 967:      * matches the requirement.
> 968:      * <p>

Empty `<p>` tag (you can simply remove this line).

modules/javafx.graphics/src/main/java/javafx/print/JobSettings.java line 1049:

> 1047:      * and it is safest to stick to selecting a standard value that
> 1048:      * matches the requirement.
> 1049:      * <p>

Empty `<p>` tag (you can simply remove this line).

-------------

PR: https://git.openjdk.java.net/jfx/pull/574