RFR: 8269638: Property methods, setters, and getters in printing API should be final [v2]

Phil Race prr at openjdk.java.net
Mon Jul 12 22:04:25 UTC 2021


> - Make various setters and getters and properties final as needed
> - Move documentation to the property so the setters and getters inherit it, with an exception for the special case of JobSettings.setPageRanges()
> - Override toString() on the properties in JobSettings so it doesn't delegate to the JobSettings class.
> - Add a manual test program just so you can see what toString() does. No pass or fail, just informative.
> 
> This will need a CSR but I won't create that until the review is done.

Phil Race has updated the pull request incrementally with one additional commit since the last revision:

  8269638: Property methods, setters, and getters in printing API should be final

-------------

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/574/files
  - new: https://git.openjdk.java.net/jfx/pull/574/files/4fad1a0d..380ad63f

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jfx&pr=574&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=574&range=00-01

  Stats: 33 lines in 2 files changed: 11 ins; 18 del; 4 mod
  Patch: https://git.openjdk.java.net/jfx/pull/574.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/574/head:pull/574

PR: https://git.openjdk.java.net/jfx/pull/574


More information about the openjfx-dev mailing list