RFR: 8269638: Property methods, setters, and getters in printing API should be final [v3]

Phil Race prr at openjdk.java.net
Thu Jul 15 18:06:52 UTC 2021


On Thu, 15 Jul 2021 04:30:42 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8269638: Property methods, setters, and getters in printing API should be final
>
> modules/javafx.graphics/src/main/java/javafx/print/PrinterJob.java line 226:
> 
>> 224:      * Setting a null value for printer will install the default printer.
>> 225:      * Setting the current printer has no effect.
>> 226:      * @return the <code>Printer</code> for this job
> 
> If we are using {@code Printer} preferred pattern above for new addition, probably we should use here too, no?

done

> tests/manual/printing/JobSettingsInfo.java line 45:
> 
>> 43: import javafx.scene.Scene;
>> 44: import javafx.scene.control.TextArea;
>> 45: import javafx.scene.layout.*;
> 
> One more place wildcard overlooked...Since we changed one case above, probably it can also be rectified..

done

-------------

PR: https://git.openjdk.java.net/jfx/pull/574


More information about the openjfx-dev mailing list