RFR: 8269638: Property methods, setters, and getters in printing API should be final [v4]
Prasanta Sadhukhan
psadhukhan at openjdk.java.net
Fri Jul 16 04:07:25 UTC 2021
On Thu, 15 Jul 2021 18:06:44 GMT, Phil Race <prr at openjdk.org> wrote:
>> - Make various setters and getters and properties final as needed
>> - Move documentation to the property so the setters and getters inherit it, with an exception for the special case of JobSettings.setPageRanges()
>> - Override toString() on the properties in JobSettings so it doesn't delegate to the JobSettings class.
>> - Add a manual test program just so you can see what toString() does. No pass or fail, just informative.
>>
>> This will need a CSR but I won't create that until the review is done.
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>
> 8269638: Property methods, setters, and getters in printing API should be final
looks good..
However I have a different question...I was looking at printerProperty and I saw In l182, we are not checking for getDefaultPrinter() returns null or not but in l120, we do...Is it not required in l182?
-------------
PR: https://git.openjdk.java.net/jfx/pull/574
More information about the openjfx-dev
mailing list