[jfx17] RFR: 8270314: TreeTableCell: inconsistent naming for tableRow and tableColumn property methods

Kevin Rushforth kcr at openjdk.java.net
Fri Jul 16 12:23:53 UTC 2021


On Fri, 16 Jul 2021 08:14:12 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

> A quick question: why didn't you rename the updateTreeTableRow/Column as well? Pretending that the properties were writable and we had setters, these would follow the new names - regarding those update methods as expert setters, I would tend to rename them also.

I didn't look at it too closely, but my thinking was to minimize the changes to those that were necessary. You are right, though, that they should follow the same naming convention since they are effectively expert-mode setters for those properties. I'll take a closer look at those, but it does seem consistent to rename them as well.

-------------

PR: https://git.openjdk.java.net/jfx/pull/575


More information about the openjfx-dev mailing list