RFR: 8269639: [macos] Calling stage.setY(0) twice causes wrong popups location [v2]

[Jose Pereda]

On Sat, 17 Jul 2021 12:23:47 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Jose Pereda has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address feedback from reviewer
>
> tests/system/src/test/java/test/javafx/stage/StageAtTopPositionTest.java line 25:
> 
>> 23:  * questions.
>> 24:  */
>> 25: package test.javafx.stage;
> 
> Minor: can you add a blank line before the `package` statement? (I realize we have a few existing classes that don't follow this)

Done

> tests/system/src/test/java/test/javafx/stage/StageAtTopPositionTest.java line 72:
> 
>> 70:             stage.setY(400);
>> 71:             stage.addEventHandler(WindowEvent.WINDOW_SHOWN, e ->
>> 72:                                     Platform.runLater(startupLatch::countDown));
> 
> Minor: indentation is a bit off if you intended to line it up.

Fixed

> tests/system/src/test/java/test/javafx/stage/StageAtTopPositionTest.java line 86:
> 
>> 84:             }
>> 85:         } catch (InterruptedException ex) {
>> 86:             fail("Unexpected exception: " + ex);
> 
> If you add `throws Exception` to the method, you can simplify this and replace the try/catch block with:
> 
> 
>     assertTrue("Timeout waiting for FX runtime to start",
>                startupLatch.await(15, TimeUnit.SECONDS));
> 
> 
> (most of our newer tests do this)

Done

-------------

PR: https://git.openjdk.java.net/jfx/pull/580