RFR: 8253351: MediaPlayer does not display an mp4 if there no speakers connected to the PC's [v2]

Alexander Matveev almatvee at openjdk.java.net
Mon Jul 26 22:23:20 UTC 2021


> Fixed by not failing initialization if DSERR_NODRIVER is returned, which will be return if device is not present at all. Fixed format initialization even if DirectSound device was not created in case if audio device will arrive after playback started. Since we already handle correctly device arrival after playback started, audio will resume if device is enabled or USB audio card is plugged back. Due to lack of access to USB audio device, it was tested by disabling sound card via Device Manager, then starting playback (video plays, but not audio) and then enabling device and once enabled audio will start playing.

Alexander Matveev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:

 - Merge remote-tracking branch 'upstream/master' into JDK-8253351
 - 8253351: MediaPlayer does not display an mp4 if there no speakers connected to the PC's

-------------

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/586/files
  - new: https://git.openjdk.java.net/jfx/pull/586/files/731b4cd6..2b06faed

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jfx&pr=586&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=586&range=00-01

  Stats: 326714 lines in 6075 files changed: 179112 ins; 103349 del; 44253 mod
  Patch: https://git.openjdk.java.net/jfx/pull/586.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/586/head:pull/586

PR: https://git.openjdk.java.net/jfx/pull/586


More information about the openjfx-dev mailing list