[jfx17] Integrated: 8240640: [macos] Wrong focus behaviour with multiple Alerts
Pankaj Bansal
pbansal at openjdk.java.net
Tue Jul 27 13:25:31 UTC 2021
On Mon, 19 Jul 2021 19:52:05 GMT, Pankaj Bansal <pbansal at openjdk.org> wrote:
> The bug is a regression as a result of fix done for JDK-8227366 and is reproducible on Linux and Mac. This fix is being reverted in this change and a new bug (JDK-8271054) has been created to redo the JDK-8227366
>
> An automated testcase is being added to make sure similar regression is not introduced when working on the redo bug. The automated testcase fails without the current change and passes after the change.
>
> The testcase works fine on Mac and Linux, but I see some issues in windows. The stage is minimised after calling stage.show without calling stage.setAlwaysOnTop(true). I see that there are other tests like DualWindowsTest.java which are failing for same reason. Also, if I remove the stage.setAlwaysOnTop(true) from tests like FocusParentWindowOnChildCloseTest.java, the stage remains minimised there as well. This seems wrong as calling stage.setAlwaysOnTop(true) should not be required to bring stage window in focus on running the test. This may be an issue on my Window machine or something similar. I hope reviewers can shed some light on this.
This pull request has now been integrated.
Changeset: 2cd5d1fd
Author: Pankaj Bansal <pbansal at openjdk.org>
URL: https://git.openjdk.java.net/jfx/commit/2cd5d1fd0fd3e7d974b46bd43a6f98dbca6f28c0
Stats: 135 lines in 2 files changed: 134 ins; 0 del; 1 mod
8240640: [macos] Wrong focus behaviour with multiple Alerts
Reviewed-by: kcr, arapte
-------------
PR: https://git.openjdk.java.net/jfx/pull/581
More information about the openjfx-dev
mailing list