[jfx17] RFR: 8250590: Classes and methods in the javafx.css package are missing documentation [v3]
Nir Lisker
nlisker at openjdk.java.net
Wed Jul 28 09:40:33 UTC 2021
On Tue, 27 Jul 2021 12:44:58 GMT, Ajit Ghaisas <aghaisas at openjdk.org> wrote:
>> This PR corrects/adds missing documentation for classes in javafx.css package.
>
> Ajit Ghaisas has updated the pull request incrementally with one additional commit since the last revision:
>
> 8250590 - add missing @since tag
I have spotted some missing docs:
* `CompoundSelector` missing docs for methods overriden from `Object`.
* `CssMetaData` is missing docs for methods `hashCode()`, `getConverter()` and `getProperty()`.
* `CssParser.ParseError` for `toString()`.
I stopped checking at this point. It seems that the the script warning for missing docs isn't looking at overriden methods. `getProperty()` and `getConverter()` were not caught since they have an `@return` doc, but no method summary.
-------------
PR: https://git.openjdk.java.net/jfx/pull/589
More information about the openjfx-dev
mailing list