Eclipse: any way to checkout a PR for review?
Jeanette Winzenburg
fastegal at swingempire.de
Wed Jul 28 09:45:21 UTC 2021
Zitat von Nir Lisker <nlisker at gmail.com>:
> I'm not really sure what you mean. If you pull from the remote that the PR
> is on and checkout the remote branch, is it not good enough for a review?
>
yeah, that's what I meant - without having been too clear - with
fork-the-fork :) What I had hoped for was some hidden eclipse magic to
directly access a PR as branch (from jfx) - something like the Pull
requests tab in GitHub Desktop. Which under the hood adds a new remote
to the fork that created the pr. And that's what I ended up with: add
that remote manually and checkout the branch.
Thanks for your input!
-- Jeanette
> On Tue, Jul 27, 2021 at 2:16 PM Jeanette Winzenburg <fastegal at swingempire.de>
> wrote:
>
>>
>> when reviewing a PR with only a few files changed, I simply create a
>> local branch and c&p the changes (*cough, pretty sure there's a better
>> way, but then that's the most simple ;).
>>
>> With changes to many files (like f.i.
>> https://github.com/openjdk/jfx/pull/569) that still would be doable,
>> but rather cumbersome - so looking for something like "gh pr checkout
>> 569" (not that I ever tried that, just copied from the doc :) inside
>> Eclipse.
>>
>> An alternative might be to fork-the-fork .. ?
>>
>> -- Jeanette
>>
>>
More information about the openjfx-dev
mailing list