RFR: 8253351: MediaPlayer does not display an mp4 if there no speakers connected to the PC's [v2]
Kevin Rushforth
kcr at openjdk.java.net
Wed Jul 28 16:01:41 UTC 2021
On Mon, 26 Jul 2021 22:23:20 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:
>> Fixed by not failing initialization if DSERR_NODRIVER is returned, which will be return if device is not present at all. Fixed format initialization even if DirectSound device was not created in case if audio device will arrive after playback started. Since we already handle correctly device arrival after playback started, audio will resume if device is enabled or USB audio card is plugged back. Due to lack of access to USB audio device, it was tested by disabling sound card via Device Manager, then starting playback (video plays, but not audio) and then enabling device and once enabled audio will start playing.
>
> Alexander Matveev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>
> - Merge remote-tracking branch 'upstream/master' into JDK-8253351
> - 8253351: MediaPlayer does not display an mp4 if there no speakers connected to the PC's
Looks good to me. I didn't fully verify the fix on a system without speakers (although I did some limited testing), but did run a set of regression tests.
-------------
Marked as reviewed by kcr (Lead).
PR: https://git.openjdk.java.net/jfx/pull/586
More information about the openjfx-dev
mailing list