[jfx17] RFR: 8250590: Classes and methods in the javafx.css package are missing documentation [v3]
Ajit Ghaisas
aghaisas at openjdk.java.net
Thu Jul 29 07:20:36 UTC 2021
On Wed, 28 Jul 2021 23:25:34 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
> > > I think `getProperty()` and `getConverter()` should be fixed in this PR.
> >
> >
> > There could be more methods like that. Maybe the script should check specifically for a missing summary?
>
> We just used the `javadoc` tool to find them, so would need support from the `javadoc` tool itself. I looked through all of the docs and only found one more: `ParsedValue.getValue()`.
I found few more such methods in javafx.css package using "find in files" in my editor and fixed them.
- CssMetaData.getProperty()
- CssMetaData.getConverter()
- ParsedValue.getValue()
- PseudoClassImpl.getPseudoClassName()
- PseudoClassImpl.toString()
- SimpleSelector.getPseudoclasses()
Interestingly this is not only limited to javafx.css package, but spread across all JavaFX modules.
I have filed [JDK-8271460](https://bugs.openjdk.java.net/browse/JDK-8271460) for fixing this.
-------------
PR: https://git.openjdk.java.net/jfx/pull/589
More information about the openjfx-dev
mailing list