[jfx17] RFR: 8250590: Classes and methods in the javafx.css package are missing documentation [v4]

Nir Lisker nlisker at openjdk.java.net
Thu Jul 29 09:17:35 UTC 2021


On Thu, 29 Jul 2021 08:43:59 GMT, Ajit Ghaisas <aghaisas at openjdk.org> wrote:

>> This PR corrects/adds missing documentation for classes in javafx.css package.
>
> Ajit Ghaisas has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8250590 - fix review comments

In `Declaration` something is wrong with the html rendering in the last lines, the columns are misaligned:
![image](https://user-images.githubusercontent.com/37422899/127464002-9d77ff25-c5b7-4058-9797-5379c62ded8d.png)

Same with `Stylesheet`.

Does it comes out like that just for me? I didn't see anything wrong with the code after a quick look.

Also, `Match.compareTo` is overriden from `Comparable<Match>` without a doc, but maybe something needs to be specified there about what is being compared or for what purpose `Comparable` is implemented to begin with?

-------------

PR: https://git.openjdk.java.net/jfx/pull/589


More information about the openjfx-dev mailing list