[jfx17] RFR: 8250590: Classes and methods in the javafx.css package are missing documentation [v5]

[Ajit Ghaisas]

On Thu, 29 Jul 2021 17:41:50 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Ajit Ghaisas has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8250590 - fix review comments
>
> modules/javafx.graphics/src/main/java/javafx/css/Selector.java line 102:
> 
>> 100:     /**
>> 101:      * Gets whether this {@code Selector} applies to the given {@code Styleable}.
>> 102:      * It is the same as the {@link createMatch} method except it returns a boolean rather than a {@code Match}.
> 
> I see you changed this from `matches` to `createMatches`, since there is no `matches` method. However, I now wonder if this comment is correct in the first place. The `createMatch` method doesn't take a `Styleable` so it seems unlikely that it would be semantically equivalent to calling `createMatches`. Unless you can figure out what was meant by the original comment, it might best to just remove it.

It is out of place comment. I think, it is better to remove it.

-------------

PR: https://git.openjdk.java.net/jfx/pull/589