RFR: 8263095: Provide a way for a custom control to indicate that its userAgentStyleSheet has changed

Kevin Rushforth kcr at openjdk.java.net
Wed Jun 2 21:58:34 UTC 2021


On Wed, 2 Jun 2021 03:02:26 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

> Don't worry about the CSR for now, someone will create it when the review is near completion. However, since this is an enhancement, you should discuss it first in the mailing list as explained in the README file of the repo.

Exactly. The discussion should happen on openjfx-dev at openjdk.java.net. Specifically, the place to start is with the newly proposed API and behavioral changes. This is what is important to get general agreement / buy-in on. Any newly proposed public methods need to be clearly documented and justified. Also, there needs to be a discussion as to whether this change in behavior should be done unconditionally, which the current PR proposes to do, or whether this behavior should be "opt in".

Since we haven't yet had the discussion, this PR is not yet ready to be reviewed. It can be used for illustrative purposes as long as the focus is on the public API and behavioral changes and not (yet anyway) on the code.

-------------

PR: https://git.openjdk.java.net/jfx/pull/525


More information about the openjfx-dev mailing list