RFR: 8234920: Add SpotLight to the selection of 3D light types [v19]

[Nir Lisker]

On Wed, 2 Jun 2021 12:12:39 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

> Also I noticed that we are not providing a position property for both Point and Spot light. However as of now it seems not required. Should we consider to add it in future ?

The translate/layout transforms set the position. The direction is different because the rotation transforms are not easy to work with and users will want something like a "loot at" function. That was a big point of discussion in the review process.

> modules/javafx.graphics/src/main/java/javafx/scene/SpotLight.java line 145:
> 
>> 143:      * The angle of the spotlight's inner cone (as shown in the class doc image). A point whose angle to the light's
>> 144:      * origin is less than this angle is not attenuated by the spotlight factor ({@code spot = 1}). At larger angles,
>> 145:      * the light intensity starts to drop.
> 
> The intensity inside inner cone is not attenuated, so the drop in intensity happens only in outer cone. Then the statement `At larger angles, the light intensity starts to drop.` may not be needed here. The drop should be described only with outer angle.

I would say that the outer cone is defined by both angles (from inner to outer). When I write about an angle, I would like to say what happens both before and after it.

-------------

PR: https://git.openjdk.java.net/jfx/pull/334