RFR: 8268152: gstmpegaudioparse does not provides timestamps for HLS MP3 streams

Thu Jun 3 22:07:54 UTC 2021

On Thu, 3 Jun 2021 09:37:18 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

> With recent GStreamer update gstmpegaudioparse no longer provides audio buffers with valid timestamps. This issue is only reproducible with MP3 HTTP Live Stream and was noticed on Linux. I think Windows audio decoder handles such case better and thus MP3 HLS works fine. I did not figure out why it behaves this way and for now fix is reverting gstmpegaudioparse changeset which caused it. Follow up issue will be filed to investigate why javasource and/or hlsprogressbuffer no longer compatible with gstmpegaudioparse and gstmpegaudioparse cannot figure out correct PTS. Also, fixed potential null pointer reference for buffers with invalid PTS.

Looks good. I did a build / test on all three platforms.

-------------

Marked as reviewed by kcr (Lead).

PR: https://git.openjdk.java.net/jfx/pull/526