RFR: 8267059: Gradle :clean and :apps tasks fail on Windows if ANT_HOME contains spaces [v2]

Michael Strauß mstrauss at openjdk.java.net
Fri Jun 4 05:04:17 UTC 2021


> This PR fixes an issue when building OpenJFX on Windows and command-line arguments contain paths with spaces.
> 
> The problem is that on Windows, `ant` is invoked via `cmd`, which leads to quotes being interpreted twice. This can be fixed with the option `cmd /s`, which prevents interpreting quotes on the rest of the command line. The result is as if the rest of the command line had been typed verbatim at the command prompt.

Michael Strauß has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:

 - Merge branch 'master' into fixes/JDK-8267059
 - Use cmd /s option when building on Windows

-------------

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/499/files
  - new: https://git.openjdk.java.net/jfx/pull/499/files/b11d0b1e..111b23d6

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jfx&pr=499&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=499&range=00-01

  Stats: 1534 lines in 75 files changed: 976 ins; 254 del; 304 mod
  Patch: https://git.openjdk.java.net/jfx/pull/499.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/499/head:pull/499

PR: https://git.openjdk.java.net/jfx/pull/499


More information about the openjfx-dev mailing list