RFR: 8268120: Allow hardware cursor to be used on Monocle-EGL platforms [v2]

Alexander Scherbatiy alexsch at openjdk.java.net
Fri Jun 4 12:28:58 UTC 2021


On Thu, 3 Jun 2021 11:41:02 GMT, Johan Vos <jvos at openjdk.org> wrote:

>> Add EGL cursor implementation (Java + native) and the link to low-level drivers.
>> Fix for JDK-8268120
>
> Johan Vos has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix typo after last-minute inversion (make hwcursor default instead of swcursor)

modules/javafx.graphics/src/main/native-glass/monocle/egl/egl_ext.h line 39:

> 37: 
> 38: // initialize the EGL system with the specified handle
> 39: extern jboolean doEglInitialize(void* handle);

Is it possible to declare arguments as `jlong eglDisplay` here instead of `void* handle` as it is done in other methods?
As I see nEglInitialize() passes eglDisplay on the java side:
https://github.com/openjdk/jfx/blob/47700d8ef0175d4b457bb658371d2da4ec0a8181/modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/EGLAcceleratedScreen.java#L48
but it needs to convert it to a ptr in the native code:
https://github.com/openjdk/jfx/blob/47700d8ef0175d4b457bb658371d2da4ec0a8181/modules/javafx.graphics/src/main/native-glass/monocle/egl/eglBridge.c#L46

-------------

PR: https://git.openjdk.java.net/jfx/pull/527


More information about the openjfx-dev mailing list