RFR: 8267059: Gradle :clean and :apps tasks fail on Windows if ANT_HOME contains spaces [v2]

[Kevin Rushforth]

On Fri, 4 Jun 2021 05:04:17 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

>> This PR fixes an issue when building OpenJFX on Windows and command-line arguments contain paths with spaces.
>> 
>> The problem is that on Windows, `ant` is invoked via `cmd`, which leads to quotes being interpreted twice. This can be fixed with the option `cmd /s`, which prevents interpreting quotes on the rest of the command line. The result is as if the rest of the command line had been typed verbatim at the command prompt.
>
> Michael Strauß has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'master' into fixes/JDK-8267059
>  - Use cmd /s option when building on Windows

Looks fine. I tested it on Windows with / without spaces in `ANT_HOME` and it does what I would expect. I sanity tested it on Linux.

> On Ubuntu 20.04 ... The :apps task fails before and after the fix

Maybe something with the version of Java you are using? It runs fine my system, and the GitHub actions build is fine.

-------------

Marked as reviewed by kcr (Lead).

PR: https://git.openjdk.java.net/jfx/pull/499