RFR: 8267551: Support loading images from inline data-URIs [v13]

[Michael Strauß]

On Fri, 4 Jun 2021 22:14:12 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Michael Strauß has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 15 commits:
>> 
>>  - Merge branch 'master' into feature/image-datauri
>>    
>>    # Conflicts:
>>    #	modules/javafx.graphics/src/test/java/test/com/sun/javafx/iio/ImageStorageTest.java
>>  - Accept regular file paths, change javadoc
>>  - Merge branch 'openjdk:master' into feature/image-datauri
>>  - Rename DataURI.isValidURI
>>  - Reverted a change
>>  - Allow leading and trailing whitespace in data URI
>>  - Removed test
>>  - Changed data URI detection
>>  - Merge branch 'master' into feature/image-datauri
>>  - Moved test
>>  - ... and 5 more: https://git.openjdk.java.net/jfx/compare/7b7050c4...315523c5
>
> modules/javafx.graphics/src/main/java/javafx/scene/image/Image.java line 612:
> 
>> 610:     /**
>> 611:      * Constructs an {@code Image} with content loaded from the specified
>> 612:      * image file. The {@code url} parameter can be one of the following:
> 
> I would not use the words "image file" in the first sentence. I recommend to restore this to "url".

Done.

> modules/javafx.graphics/src/main/java/javafx/scene/image/Image.java line 624:
> 
>> 622:      * <p>
>> 623:      * If a URL uses the "data" scheme, the data must be base64-encoded
>> 624:      * and the MIME type must either be empty or a subtype of the
> 
> These two paragraphs might be better as part of the class docs (which is where we list the supported image formats).

Done.

> modules/javafx.graphics/src/main/java/javafx/scene/image/Image.java line 638:
> 
>> 636:     /**
>> 637:      * Constructs an {@code Image} with content loaded from the specified
>> 638:      * image file. The {@code url} parameter can be one of the following:
> 
> Similar comment. Maybe something like this for the first sentence?
> 
> 
> Constructs an {@code Image} with content loaded from the specified url using the specified parameters.

Done.

-------------

PR: https://git.openjdk.java.net/jfx/pull/508