RFR: 8267551: Support loading images from inline data-URIs [v13]

Kevin Rushforth kcr at openjdk.java.net
Sat Jun 5 15:56:57 UTC 2021


On Sat, 5 Jun 2021 15:08:29 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

>> modules/javafx.graphics/src/main/java/com/sun/javafx/util/DataURI.java line 185:
>> 
>>> 183: 
>>> 184:         return originalUri.substring(0, originalUri.length() - originalData.length())
>>> 185:             + originalData.substring(0, 14) + "..." + originalData.substring(originalData.length() - 14);
>> 
>> Why truncate it?
>
> The idea was to not clutter logs with large pieces of data. Do you think that the entire data string should be logged?

Your explanation is fine. And since this is an internal class, it doesn't matter all that much.

-------------

PR: https://git.openjdk.java.net/jfx/pull/508


More information about the openjfx-dev mailing list