RFR: 8267551: Support loading images from inline data-URIs [v14]
Kevin Rushforth
kcr at openjdk.java.net
Sat Jun 5 16:03:59 UTC 2021
On Sat, 5 Jun 2021 15:42:22 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:
>> This PR adds support for loading images from [inline data URIs](https://en.wikipedia.org/wiki/Data_URI_scheme), which is also widely supported by web browsers. This enables developers to package small images in CSS files, rather than separately deploying the images alongside the CSS file.
>
> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
>
> Addressed review comments
Yes, it is a good question as to whether we should add Data URI support in the core of JavaFX or provide it via some other means. I agree that we wouldn't want to implement it in JavaFX with a pluggable protocol handler, so if we go that route we will end up pushing it off to the app.
The other alternative that was mentioned (as a comment in the JBS bug) was to push for direct support in the JDK. Since that was requested some years ago and rejected -- see [JDK-4188739](https://bugs.openjdk.java.net/browse/JDK-4188739) -- I doubt that is likely.
My gut feel is that adding Data URI support to JavaFX is a worthwhile feature, but it might warrant further discussion.
-------------
PR: https://git.openjdk.java.net/jfx/pull/508
More information about the openjfx-dev
mailing list