RFR: 8267551: Support loading images from inline data-URIs [v13]

[Kevin Rushforth]

On Sat, 5 Jun 2021 15:44:38 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

>> modules/javafx.graphics/src/main/java/javafx/css/converter/URLConverter.java line 98:
>> 
>>> 96:     }
>>> 97: 
>>> 98:     private URL resolve(String stylesheetUrl, String resource) {
>> 
>> Why was this change done? It seems unnecessary and possibly unwanted.
>
> `resource` is never `null` at this point, and it is already trimmed. Also, contrary to the comment, I cannot see this method being used anywhere in tests, so I made it private.

If that is guaranteed by all callers of this method (which is easier to check now that you made it private), this is fine.

-------------

PR: https://git.openjdk.java.net/jfx/pull/508