RFR: 8267418: IntelliJ build and test of JavaFX does not work [v4]

[Ambarish Rapte]

On Wed, 2 Jun 2021 07:11:54 GMT, Marius Hanl <mhanl at openjdk.org> wrote:

>> ~~Question: I was wondering, should I create a ticket for this as well? Given the fact that I don't have an https://bugs.openjdk.java.net account, I need to use the official bug reporting tool, which looked a bit overkill to me since someone needs to check my created ticket, while this PR is only affecting the IntelliJ IDE with OpenJFX and not the JavaFX platform directly.~~
>> EDIT: Thank you, Kevin. :)
>> 
>> This PR fixes the errors you get when cloning and working with OpenJFX in IntelliJ IDE:
>> - The **.idea/misc.xml** is modified to use **JDK_11** as language level instead of JDK_8. 
>> -> This is the language level shown inside the **Project Structure**. (File -> Project Structure...)
>> - The **.idea/base.iml, .idea/controls.iml, .idea/fxml.iml, .idea/web.iml, .idea/graphics.iml** are modified to include/recognize the shims (as test resource, this is very similar to the configuration inside the .classpath file from Eclipse)
>> - EDIT: The projects are now recognized by IntelliJ-gradle (**.idea/gradle.xml**, **.idea/compiler.xml**)
>> 
>> **-> With this, I can run all normal tests with IntelliJ**
>> 
>> ### What I couldn't fix yet (When I tried, it looked like IntelliJ is overriding the settings on next gradle reload): 
>> - IntelliJ is not detecting javafx.graphic inside the shims
>> - All javafx.* dependencies are not found for the system tests
>> 
>> **-> If someone has a solution, feel free to comment :)**
>
> Marius Hanl has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Reverted whitespace made by IntelliJ

I tested with IntelliJ IDEA 2021.1.2 (Community Edition) Build #IC-211.7442.40, built on June 1, 2021.

I see no side effects of this change. However, I also don't see what you see too.
I tried it with a fresh clone of repository. 
The build from IntelliJ's inbuilt terminal worked without this change too, that terminal picks JDK/gradle/ant that was set in bashrc. 

I also don't see the modules in gradle window. Here is the screenshot that I see when the project(with this PR change) is loaded for first time in the IntelliJ.
![image](https://user-images.githubusercontent.com/11330676/120957254-f6751700-c772-11eb-9fb4-51668d6f4e24.png)

Is it possible that some local changes on your machine/repo result in what you see?
Some idea files are ignored using .gitignore file, so they get modified they won't be shown in 'git status'
**from .gitignore file**

# Ignore IntelliJ files
.idea/tasks.xml
.idea/workspace.xml
.idea/inspectionProfiles/**
.idea/copyright/profiles_settings.xml
.idea/codeStyles/**
.idea/checkstyle-idea.xml

It would be helpful to compare those files before and after loading the project in IntelliJ.
Also, can you test the PR once, by cloning a fresh copy of repo and then apply the PR.

-------------

PR: https://git.openjdk.java.net/jfx/pull/506