RFR: 8244075: Accelerator of ContextMenu's MenuItem is not removed when ContextMenu is removed from Scene [v2]

Ajit Ghaisas aghaisas at openjdk.java.net
Wed Jun 9 10:36:16 UTC 2021


On Tue, 8 Jun 2021 11:51:32 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> Issue:
>> There are several issues related to Accelerator of MenuItem of a ConextMenu set on Control.
>> 1. Accelerator of ContextMenu's MenuItem is not removed when ContextMenu is removed from Scene
>> 2. Accelerator is not updated correctly when the Control is removed from a Scene and Added to a different Scene
>> 3. Accelerator is not removed from Scene when the anchor node is removed from Scene and then it's ContextMenu is set to null
>> 
>> Fix:
>> The accelerator should be added or removed correctly according to the Scene property of the anchor node. 
>> The issue#3 in above list is only fixed for Button and fails for other Controls. A test is added for this scenario and I shall report a new issue to address it.
>> Added tests that fails before and pass after the fix.
>
> Ambarish Rapte has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update @ignore() with bugid

Marked as reviewed by aghaisas (Reviewer).

-------------

PR: https://git.openjdk.java.net/jfx/pull/515


More information about the openjfx-dev mailing list