RFR: 8255015: Inconsistent illumination of 3D shape by PointLight [v2]

Andreas Heger github.com+85555697+andreas-heger at openjdk.java.net
Wed Jun 9 18:27:37 UTC 2021


> The inconsistent illumination happens on Macs with retina displays only if the 3D shape is placed in a SubScene. The light sources are located with wrong coordinates in sub scenes and this causes a different illumination. The wrong coordinates for the light sources come from the fact that the retina pixel scale factors are not used in a SubScene.
> 
> With this pull request, the retina pixel scale factors will be also used in SubScenes and this should resolve the bug
> [https://bugs.openjdk.java.net/browse/JDK-8255015](url)

Andreas Heger has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR.

-------------

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/530/files
  - new: https://git.openjdk.java.net/jfx/pull/530/files/66b361a0..ca250364

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jfx&pr=530&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=530&range=00-01

  Stats: 4 lines in 1 file changed: 0 ins; 4 del; 0 mod
  Patch: https://git.openjdk.java.net/jfx/pull/530.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/530/head:pull/530

PR: https://git.openjdk.java.net/jfx/pull/530


More information about the openjfx-dev mailing list